Disable mpi backend build when found xccl #1923
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,6 +53,10 @@ if(USE_XCCL) | |||
| caffe2_update_option(USE_XCCL OFF) | |||
| caffe2_update_option(USE_C10D_XCCL OFF) | |||
| update_caffe2_macros_file() | |||
There was a problem hiding this comment.
The else() clause is unclear without context. Consider adding a comment to explain that this branch executes when XCCL is found and enabled, to improve code readability.
Suggested change
| update_caffe2_macros_file() | |
| update_caffe2_macros_file() | |
| # XCCL is found and enabled; disable MPI options and update macros file. |
Copilot uses AI. Check for mistakes.
chuanqi129
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.